Jiri Rechtacek wrote:
> http://wiki.netbeans.org/wiki/view/NB6AutoupdateChanges

Comments follow; feel free to paste the nontrivial or controversial ones
into a new section in the document.

1. If the default value of OpenIDE-Module-Show-In-AutoUpdate-Client is
true, then there is there any reason to ever explicitly set it to true?

2. If we add an 'eager' attr to the UC.xml DTD, we should also add an
'autoload' attr for symmetry; maybe we will want it in the future.

3. If low-level regular modules are hidden, it is still possible for
them to be disabled without the user's knowledge or intent. Suppose for
sake of example that someone has a hard dep on Core - Windows
(o.n.c.windows) from a module in the uml cluster, for whatever reason -
maybe an impl dep or something for some hacky reason; but that this is
the _only_ such direct dep on that module. Now suppose the user has UML
support installed but decides to disable it. What happens? o.n.c.windows
is now a hidden module which was "used" only by a visible module which
is now being disabled. So, it gets turned off - and the IDE explodes.
This is why I believe that none of the proposals offered so far
adequately account for platform modules.

4. "Legend of diagram" is confusing. Bold and dash-line have same
description; I guess missing "=true" and "=false? "autoupdate" probably
-> "autoload"? Dashed line between modules (from eager module) has no
legend, not sure what it means.

5. In diagram there are several apparent errors. "Projects UI" is not
autoload. "Projects Support" does not exist. "Projects API" does not
depend on "Projects UI". I would suggest using an actual example -
really look at some module dependencies and work out the details.

6. [As I wrote to Trung] What would happen if you have a visible
autoload or eager module? There is no explanation here and I think it
would make no sense - you cannot manipulate it like a regular module.

7. In diagram, what happens if I disable "Ruby" (but leave on "Ruby
Debugging" and "Ruby Editing")? Nothing, apparently. So why is it there?

8. In example B1, wouldn't "Ruby/JRuby Bridge" also be installed? I
guess that is question B4? Confusing. Would like to see complete
examples so I don't have to skip around the document to see how the
proposed system would behave.

9. "What will be installed if I uninstall JRuby?" - typo?

10. "if Autoupdate does Install operation then installs eager module in
that case of all its dependencies could be satisfied" is likely
incorrect. It should (IMO) only install it in case the eager module's
dependencies would not be satisfied if the rest of the install operation
were not taking place. Otherwise, the first time you installed _any_
module, you could get a bunch of totally unrelated eager modules
installed as well. BTW this is also one place where you need to have the
autoload flag in UC.xml, because you _must_ install any currently
missing autoload deps of the new eager module but _must not_ install
non-autoload deps.

11. "we can declare another one attribute in module's manifest, e.g.
OpenIDE-Module-Is-Eager" - no. The eager and autoload status is already
defined in config/Modules/*.xml. I agree that eager (and autoload!)
status should be represented in the UC DTD. (It is unnecessary in the
NBM itself, i.e. Info.xml, since config/Modules/*.xml in the ZIP already
has this information.)

12. In section "Update Handling", what is the logic here for deciding
what information to display? It is not explained at all. If you look
carefully, you will see three categories from the tables above, plus one
module (in the "Java" category but that is not shown).

13. "Shouldn't PM uninstall also [those] modules depending on Ruby
Editing, i.e. Ruby and JRuby[,] rather [than] deactivat[ing] them w/o
any chance to activat[e] them again?" - yes, I think they should be
uninstalled, not just disabled. If you want them back you can get them
from AU.

-J.

-- 
jesse.glick@sun.com  netbeans.org  ant.apache.org  hudson.dev.java.net
            http://google.com/search?q=e%5E%28pi*i%29%2B1